Fix TyperState assertion failures #12827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TyperState of `FunProto#protoCtx` might already be committed by the time we call `FunProto#typedArgs` (this can happen for example with the nested TyperState in a `tryEither`), in that case we can trigger assertion errors if we touch that TyperState again. Fixed by using the nearest uncommited ancestor of the capture TyperState instead.
Flushing the reporter can force messages (apparently because of `HideNonSensicalMessages#isHidden`) which can affect the TyperState we're in the process of committing, so make sure that flushing happens before committing to not trigger any assertion. Fixes scala#12736
smarter
added
the
backport:nominated
odersky
approved these changes
Jun 15, 2021
smarter
added
backport:accepted
smarter
added
backport:done
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Aug 28, 2021
An already-committed TyperState might be committed again when errors are flushed (cf scala#12827, scala#13150) and `commit()` calls `gc()`. This operation could crash before this commit because we attempted to instantiate type variables no longer owned by the TyperState. We fix this by clearing `ownedVars` when committing a TyperState (because after committing it no longer owns any type variable). Fixes scala#13407.
olsdavis
pushed a commit
to olsdavis/dotty
that referenced
this pull request
Apr 4, 2022
An already-committed TyperState might be committed again when errors are flushed (cf scala#12827, scala#13150) and `commit()` calls `gc()`. This operation could crash before this commit because we attempted to instantiate type variables no longer owned by the TyperState. We fix this by clearing `ownedVars` when committing a TyperState (because after committing it no longer owns any type variable). Fixes scala#13407.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I nominate this PR for a backport to 3.0.1 since it fixes a regression introduced in 3.0.1-RC1 by #12519: that PR added some assertions which are now failing, this PR does not remove the assertions but fixes the underlying issues.