Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark website content as outdated. #13094

Merged
merged 1 commit into from Jul 23, 2021
Merged

Conversation

julienrf
Copy link
Collaborator

@julienrf julienrf commented Jul 17, 2021

The Scala 3 documentation is now hosted at https://docs.scala-lang.org.

There are still two issues:

  • scaladoc emits links that look like href="" https: docs.scala-lang.org scala3 reference overview.html"" (instead of href="https://docs.scala-lang.org/scala3/reference/overview.html"), I’m not sure where the problem comes from 🤔
  • the dark theme does not play well with the “aside.warning” CSS rule.

Can someone experienced with scaladoc help with these issue?

@julienrf julienrf requested a review from romanowski July 17, 2021 15:08
@julienrf
Copy link
Collaborator Author

Screenshot 2021-07-17 at 17-11-08 Overview

@julienrf julienrf marked this pull request as ready for review July 20, 2021 19:34
@julienrf
Copy link
Collaborator Author

With the help of @romanowski, I managed to fix the two issues.

Here is how it looks like in the light theme:

Screenshot 2021-07-20 at 21-32-32 Overview

And this is how it looks like in the dark theme:

Screenshot 2021-07-20 at 21-32-05 Overview

The Scala 3 documentation is now hosted at https://docs.scala-lang.org.
@julienrf julienrf merged commit 3dd91d1 into scala:master Jul 23, 2021
@julienrf julienrf deleted the deprecate-website branch July 23, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants