Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set typer phase after InteractiveDriver.run #13530

Merged
merged 1 commit into from Sep 15, 2021
Merged

Set typer phase after InteractiveDriver.run #13530

merged 1 commit into from Sep 15, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 14, 2021

Fixes #13467

@tgodzik
Copy link
Contributor Author

tgodzik commented Sep 14, 2021

Can we include this for 3.1.0 or should I do a workaround in Metals?

odersky
odersky approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

compiler/src/dotty/tools/dotc/interactive/InteractiveDriver.scala Outdated Show resolved Hide resolved
@Kordyjan Kordyjan added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Sep 14, 2021
@smarter
Copy link
Member

smarter commented Sep 14, 2021

Can we include this for 3.1.0

Yes we should backport it since it fixes a regression /cc @Kordyjan

@Kordyjan Kordyjan self-assigned this Sep 14, 2021
@Kordyjan Kordyjan mentioned this pull request Sep 15, 2021
Merged
@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Sep 15, 2021
@Kordyjan Kordyjan merged commit ea871c2 into scala:master Sep 15, 2021
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@Kordyjan Kordyjan

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completions causing AssertionError with missing implicit parameter
4 participants
@tgodzik @smarter @odersky @Kordyjan