Also consider private symbols in implicit scope of type #14054
Conversation
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/14054/ to see the changes. Benchmarks is based on merging with master (097356d) |
|
@anatoliykmetyuk Before merging this, I'd like to see what it does for the other benchmark tests, but they have not been running for a while. |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/14054/ to see the changes. Benchmarks is based on merging with master (0367d6b) |
|
Seems there is no significant slowdown. re2 did not work yet, but that should not exercise the functionality anyway. |
| object Foo { | ||
| case class Bar(i: Int) | ||
|
|
||
| private implicit class BarOps(bar: Bar) { |
There was a problem hiding this comment.
This was marked as scala2-compat, is this behavior something we also want with givens?
Should this one be visible in class Foo?
private given BarOps: AnyRef with {
extension (bar: Bar)
def twice: Bar = Bar(bar.i * 2)
}
|
@nicolasstucki yes, we want it for givens as well. I can add a test. |
Fixes #14013