Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't issue unreachable error messages for inlined code #14871

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Don't issue unreachable error messages for inlined code #14871

merged 2 commits into from
Apr 8, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 7, 2022

Fixes #8967

@odersky
Copy link
Contributor Author

odersky commented Apr 7, 2022

@nicolasstucki We need another test for #6371 that reports an error on code that is inlined. The previous test now
does not report anymore. Can you think of something?

nicolasstucki
nicolasstucki approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for #8967 LGTM.

@odersky, could you review the alternative check for #6371?

@odersky
Copy link
Contributor Author

odersky commented Apr 8, 2022

Alternative test LGTM

@odersky odersky merged commit 63da64f into scala:main Apr 8, 2022
@odersky odersky deleted the fix-8967 branch April 8, 2022 11:17
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Inlined match statements should not fail on unreachable cases
3 participants
@odersky @nicolasstucki @Kordyjan