Rewrites are UTF-8 #15622
Merged
Rewrites are UTF-8 #15622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoder has 8Kb buffer.
som-snytt
force-pushed
the
tweak/write-back
branch
from
2299b60
to
2085bfd
Compare
|
@dwijnand Not sure if anyone cares about how rewrites are written, and also not sure how this crossed my radar except while trying out rewrites, so I'm notifying you as the most finicky member of the Scala 3 team. It seems obvious to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use platform default, as UTF-8 is specified everywhere.
getBytesis the dangerous API.Instead of getting the byte array, just write through the underlying encoder (which buffers). The stream writer closes the encoder which closes the underlying stream, as I verified not for the first time in my life.