Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quick links for new ui #15912

Merged
merged 3 commits into from Oct 21, 2022
Merged

Conversation

bishabosha
Copy link
Member

fixes #15896

Screenshot 2022-08-25 at 18 30 11

@bishabosha
Copy link
Member Author

ok I need to update wherever the quick links are generated for this test

@bishabosha
Copy link
Member Author

CI should pass now

@bishabosha bishabosha requested review from szymon-rd and removed request for pikinier20 September 30, 2022 08:58
@bishabosha bishabosha assigned szymon-rd and unassigned pikinier20 Sep 30, 2022
@julienrf
Copy link
Collaborator

julienrf commented Oct 6, 2022

The script cmdScaladocTests fails. Does anyone know what is this test doing? (maybe @pikinier20? or @BarkingBad?) It seems it checks invoking scaladoc from the command-line interface and from within sbt produces the same results.

I see two failures:

  • The quick links generated by the command-line interface contain “\u00A0” instead of non-breakable spaces,
  • The source links generated by the command-line interface point to version 3.0.0 whereas the source links generated from within sbt point to version 3.2.1-RC2.

I pushed a commit that fixes the first problem.

I couldn’t figure out the reason for the second failure. I see nothing in the PR that could be the cause of it. Can you help me?

@BarkingBad
Copy link
Member

I think Jamie's commit can fix the issue, otherwise I will take a deeper look later

@bishabosha
Copy link
Member Author

my commit isn't needed I think - so if 387f7bb passes Ill drop it

@julienrf
Copy link
Collaborator

julienrf commented Oct 6, 2022

My change made the CI pass, so it seems my second issue was showing up locally only…

@bishabosha bishabosha merged commit 91b76c3 into scala:main Oct 21, 2022
@bishabosha bishabosha deleted the fix-quick-links branch October 21, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala 3 reference: Update Nav Bar links to match scala-lang.org
5 participants