Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only look for synthetic applies under TypeApply with inferred arguments #15970

Merged
merged 2 commits into from Sep 5, 2022
Merged

Only look for synthetic applies under TypeApply with inferred arguments #15970

merged 2 commits into from Sep 5, 2022

Conversation

KacperFKorban
Copy link
Member

fixes lampepfl#15969

@KacperFKorban KacperFKorban marked this pull request as ready for review September 5, 2022 06:50
odersky
odersky approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

compiler/src/dotty/tools/dotc/typer/Typer.scala Outdated Show resolved Hide resolved
@odersky odersky assigned KacperFKorban and unassigned odersky Sep 5, 2022
@KacperFKorban @odersky
Combine conditions for TypeApply in isSyntheticApply
fc65e2d 
Co-authored-by: odersky <odersky@gmail.com>
@KacperFKorban KacperFKorban merged commit 7f2638c into scala:main Sep 5, 2022
@KacperFKorban KacperFKorban deleted the fix-i15969 branch September 5, 2022 10:56
@odersky odersky mentioned this pull request Sep 8, 2022
Closed
@WojciechMazur WojciechMazur added this to the 3.2.1 backports milestone Sep 8, 2022
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Sep 8, 2022
@Kordyjan Kordyjan mentioned this pull request Sep 15, 2022
Merged
@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Sep 15, 2022
Kordyjan added a commit that referenced this pull request Sep 15, 2022
@Kordyjan
Backport "Only look for synthetic applies under TypeApply with inferr…
ccb53a9 
…ed arguments" (#16044)

Backports #15970
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Sep 15, 2022
@Kordyjan Kordyjan modified the milestones: 3.2.1 backports, 3.2.2 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@KacperFKorban KacperFKorban

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

Error when using two non conflicting apply methods in a row
4 participants
@KacperFKorban @odersky @Kordyjan @WojciechMazur