Don't render the "$" for module #17302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedelweiss
force-pushed
the
weird_module
branch
2 times, most recently
from
bdd1499
to
8263956
Compare
KacperFKorban
requested changes
Apr 21, 2023
Dedelweiss
force-pushed
the
weird_module
branch
from
c297022
to
7d23506
Compare
Change of how to correct the Issue - Add a new method "normalizedFullName" - Call the method "ClassLikeSupport" Add the ownerNameChain function - To erase the $ in all the hierarchy
Dedelweiss
force-pushed
the
weird_module
branch
from
7d23506
to
d26d076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
NameNormalizerThe ownerNameChain extension method generates a list of normalized owner names for a symbol, starting with the immediate owner and ending with the top-level owner.
The normalizedFullName extension method combines the results of ownerNameChain into a single string with "." separators.
Before:
### After:Fixes: #15880