Intrinsify constValueTuple and summonAll
#18013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
added
the
needs-minor-release
nicolasstucki
force-pushed
the
fix-15988
branch
2 times, most recently
from
1e1868c
to
3e393a9
Compare
nicolasstucki
changed the title
constValueTupleconstValueTuple and summonAll
mbovel
reviewed
Jul 12, 2023
bishabosha
reviewed
Jul 12, 2023
nicolasstucki
added
needs-minor-release
nicolasstucki
force-pushed
the
fix-15988
branch
from
bcc5a5e
to
b5ad721
Compare
The new implementation instantiates the TupleN/TupleXXL classes directly. This avoids the expensive construction of tuples using `*:`. Fixes scala#15988
nicolasstucki
force-pushed
the
fix-15988
branch
from
b5ad721
to
d71ca06
Compare
mbovel
approved these changes
Sep 22, 2023
Co-authored-by: Matt Bovel <matthieu@bovel.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation instantiates the TupleN/TupleXXL classes directly.
This avoids the expensive unrolling of tuples using
*:recursively.Fixes #15988