Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern match support in checking global objects #18127

Merged
merged 9 commits into from
Jul 14, 2023

Conversation

liufengyun
Copy link
Contributor

Pattern match in checking global objects

@liufengyun liufengyun self-assigned this Jul 5, 2023
@liufengyun liufengyun changed the title WIP - Pattern match support in checking global objects Pattern match support in checking global objects Jul 10, 2023
@liufengyun liufengyun marked this pull request as ready for review July 10, 2023 12:31
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

If the span of an error message is too long (e.g., for a huge object definition), some warnings will
be swallowed.
@liufengyun liufengyun merged commit 04eae14 into scala:main Jul 14, 2023
17 checks passed
@liufengyun liufengyun deleted the init-patmat-support branch July 14, 2023 17:07
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants