Unsuppress unchecked warnings #18377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
pos-unchecked-warnings
branch
2 times, most recently
from
ab5a866
to
fbdf7c6
Compare
dwijnand
force-pushed
the
pos-unchecked-warnings
branch
from
09dd5cb
to
534eb15
Compare
dwijnand
force-pushed
the
pos-unchecked-warnings
branch
from
534eb15
to
fa3bfce
Compare
SethTisue
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Thrilled to see these vulpix changes. cc @som-snytt
(Needs rebase now.)
|
I can only give it one ❤️. |
dwijnand
force-pushed
the
pos-unchecked-warnings
branch
from
fa3bfce
to
d66c7bf
Compare
And check it with a pos checkfile.
dwijnand
force-pushed
the
pos-unchecked-warnings
branch
from
d66c7bf
to
8f4ab67
Compare
Also, show compilation errors, if there are any, for a warn test.
dwijnand
force-pushed
the
pos-unchecked-warnings
branch
from
8f4ab67
to
3686ba0
Compare
WojciechMazur
added a commit
that referenced
this pull request
Jun 20, 2024
Backports #18377 to the LTS branch. PR submitted by the release tooling. [skip ci]
WojciechMazur
added a commit
that referenced
this pull request
Jun 20, 2024
Backports #18377 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And check it with a pos checkfile.