Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17115: Try to normalize while computing typeSize. #18386

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix #17115: Try to normalize while computing typeSize. #18386

merged 2 commits into from
Sep 1, 2023

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Aug 11, 2023

@odersky at #17115 (comment) you raised concerns with using simplified. This is a solution with tryNormalize instead, but buried inside typeSize. Is that acceptable?

odersky
odersky approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should work, yes.

@odersky odersky assigned sjrd and unassigned odersky Aug 21, 2023
@sjrd sjrd requested a review from dwijnand August 30, 2023 15:26
@sjrd sjrd assigned dwijnand and unassigned sjrd Aug 30, 2023
@sjrd
Copy link
Member Author

sjrd commented Aug 30, 2023

Review by @dwijnand as double-check?

@sjrd
Fix scala#18211: Add regression test.
eb18e53 
This is also fixed by the parent commit.
@sjrd sjrd merged commit 2ad16cd into scala:main Sep 1, 2023
17 checks passed
@sjrd sjrd deleted the fix-i17115 branch September 1, 2023 12:21
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "Fix #17115: Try to normalize while computing typeSize." t…
39c4ad6 
…o LTS (#20605)

Backports #18386 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "Fix #17115: Try to normalize while computing typeSize." t…
bb772f3 
…o LTS (#20665)

Backports #18386 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@odersky odersky odersky approved these changes

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjrd @dwijnand @odersky @Kordyjan