Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider extension methods in Space isSameUnapply #18642

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Consider extension methods in Space isSameUnapply #18642

merged 1 commit into from
Oct 16, 2023

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Oct 3, 2023

No description provided.

@dwijnand dwijnand linked an issue Oct 3, 2023 that may be closed by this pull request
Regression: "Unreachable case" warning in pattern match on StringContext #18601
Closed
@dwijnand dwijnand force-pushed the space/isSameUnapply-extension-unapply branch from fdb361f to 5a8a0ed Compare October 3, 2023 16:54
@dwijnand dwijnand marked this pull request as ready for review October 3, 2023 21:58
liufengyun
liufengyun approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwijnand dwijnand merged commit 3ea7f7a into scala:main Oct 16, 2023
18 checks passed
@dwijnand dwijnand deleted the space/isSameUnapply-extension-unapply branch October 16, 2023 20:04
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 21, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 22, 2024
@WojciechMazur
Backport "Consider extension methods in Space isSameUnapply" to LTS (#…
6f37a29 
…20716)

Backports #18642 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Regression: "Unreachable case" warning in pattern match on StringContext
3 participants
@dwijnand @liufengyun @Kordyjan