Fix #18658: Handle varargs of generic types in JSExportsGen.
#18659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
sjs-exported-varargs-of-generic-type
branch
2 times, most recently
from
44126aa
to
dcd57d1
Compare
sjrd
force-pushed
the
sjs-exported-varargs-of-generic-type
branch
from
dcd57d1
to
7668cf0
Compare
| } | ||
|
|
||
| @Test | ||
| def overloadWithVarargOfGenericValueClass(): Unit = { |
There was a problem hiding this comment.
We should also test opaque-type aliases.
When extracting the type of a varargs parameter, we have to go back to before erasure. However, that gives us a non-erased type inside as well. We need to re-erase that type to get something sensible for the back-end.
sjrd
force-pushed
the
sjs-exported-varargs-of-generic-type
branch
from
7668cf0
to
4538875
Compare
nicolasstucki
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting the type of a varargs parameter, we have to go back to before erasure. However, that gives us a non-erased type inside as well. We need to re-erase that type to get something sensible for the back-end.