Properly dealias tuple types when specializing #18724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-18638
branch
from
f942d80
to
22b273f
Compare
nicolasstucki
commented
Oct 19, 2023
| @@ -37,15 +37,14 @@ class SpecializeTuples extends MiniPhase: | |||
| end transformApply | |||
|
|
|||
| override def transformSelect(tree: Select)(using Context): Tree = tree match | |||
| case Select(qual, nme._1) if isAppliedSpecializableTuple(qual.tpe.widen) => | |||
| Select(qual, nme._1.specializedName(qual.tpe.widen.argInfos.slice(0, 1))) | |||
There was a problem hiding this comment.
The issue was that qual.tpe.widen returned U[Int, Int], isAppliedSpecializableTuple detected the tuple type through internal aliasing, but qual.tpe.widen.argInfos used the args of U[Int, Int] instead of the args of its dealiased type Tuple2[Unit, Unit]
dwijnand
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18638