Allow inner classes of universal traits #18796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
requested changes
Oct 30, 2023
| @@ -2785,11 +2785,9 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer | |||
| checkDerivedValueClass(cls, body1) | |||
|
|
|||
| val effectiveOwner = cls.owner.skipWeakOwner | |||
| if !cls.isRefinementClass | |||
| && !cls.isAllOf(PrivateLocal) | |||
| if cls.is(ModuleClass) | |||
There was a problem hiding this comment.
We do not have any neg tests for this case. The following seems to cover what we are missing.
trait Outer extends Any {
trait Inner1
trait Inner2 extends Any
class Inner3
class Inner4(a: Int) extends AnyVal // error
case class Inner5(a: Int) // error
object Inner6 // error
}
|
@nicolasstucki Can you please add the test? I am already deep in something else. |
|
I will add the tests |
Just forbid inner objects. This aligns with Scala 2 and allows us to keep Seq's definition as in Scala 2.
nicolasstucki
force-pushed
the
drop-inner-class-restriction
branch
from
9fa6e04
to
0758156
Compare
nicolasstucki
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just forbid inner objects. This aligns with Scala 2 and allows us to keep Seq's definition as in Scala 2 when porting or capture checking the standard library.