Add migration warning for XML literals in language future #19101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-19100
branch
2 times, most recently
from
dd105da
to
0a728d3
Compare
nicolasstucki
force-pushed
the
fix-19100
branch
from
0a728d3
to
45a48db
Compare
nicolasstucki
commented
Nov 30, 2023
| @@ -277,7 +277,7 @@ object MarkupParsers { | |||
| * | xmlTag1 '/' '>' | |||
| */ | |||
| def element: Tree = { | |||
| val start = curOffset | |||
| val start = curOffset // FIXME should be `curOffset - 1` (scalatest and tests/neg/i19100.scala must be updated) | |||
There was a problem hiding this comment.
@EugeneFlesselle started working on updating the scalatest submodule. I will fix this once the submodule is updated to avoid conflicts.
dwijnand
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #19100