Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ascriptionVarargsUnpacking as we never used it #19399

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Remove ascriptionVarargsUnpacking as we never used it #19399

merged 1 commit into from
Jan 9, 2024

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jan 8, 2024 •
edited

This was added by mistake.

This should be removed before 3.4.0. We will need a 3.4.0-RC2.

Ping @Kordyjan

@nicolasstucki nicolasstucki added this to the 3.4.0 milestone Jan 8, 2024
@nicolasstucki nicolasstucki added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jan 9, 2024
@nicolasstucki nicolasstucki marked this pull request as ready for review January 9, 2024 08:03
@nicolasstucki nicolasstucki merged commit 91db06a into scala:main Jan 9, 2024
19 checks passed
@nicolasstucki nicolasstucki deleted the remove-ascriptionVarargsUnpacking branch January 9, 2024 15:31
@Kordyjan Kordyjan mentioned this pull request Jan 18, 2024
Merged
@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jan 18, 2024
Kordyjan added a commit that referenced this pull request Jan 18, 2024
@Kordyjan
Backport "Remove ascriptionVarargsUnpacking as we never used it" (#…
20d9f65 
…19475)

Backports #19399 to 3.4.0
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees

@dwijnand dwijnand

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasstucki @dwijnand @Kordyjan