Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tests that require scala-compiler #1989

Merged
merged 1 commit into from Feb 18, 2017
Merged

Disable tests that require scala-compiler #1989

merged 1 commit into from Feb 18, 2017

Conversation

smarter
Copy link
Member

@smarter smarter commented Feb 16, 2017

This is necessary if we ever want to get rid of our dependency on scala-compiler

@smarter smarter requested a review from odersky February 16, 2017 22:37
odersky
odersky reviewed Feb 18, 2017
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a sub-directory scalac-dependent under disabled and move them there? That way, we avoid hunting the tests down in disabled to verify if we should re-enable them.

Otherwise LGTM.

@smarter
Disable tests that require scala-compiler
5aac086 
This is necessary if we ever want to get rid of our dependency on scala-compiler
@smarter smarter merged commit f3f1c46 into scala:master Feb 18, 2017
@allanrenucci allanrenucci deleted the remove/scalac-tests branch December 14, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smarter @odersky