Revive the Scala.js backend. #5143
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
|
@allanrenucci (since you seem to update |
|
The Dockerfile for the drone image is at https://github.com/lampepfl/dotty-drone/blob/master/dotty-docker/Dockerfile. You need to add I can do the last step for you on Monday |
|
@sjrd I published a new image |
|
@allanrenucci Thanks! It works :) |
sjrd
force-pushed
the
revive-scalajs
branch
from
afd0847
to
426d63d
Compare
sjrd
force-pushed
the
revive-scalajs
branch
2 times, most recently
from
78ea187
to
91752a7
Compare
This partially reverts 06a3d47 to bring back Dotty.js from the dead. - Scala.js was upgraded to 1.0.0-M6, and the back-end was updated to reflect changes that have happened in the Scala 2 back-end since the initial implementation of the Dotty.js back-end. - The backend was initially removed because of scala#1574, I don't see why GetClass has a requirement on FunctionalInterfaces, so I just removed it ¯\_(ツ)_/¯ - The Scala.js backend explodes when extending a Scala 2 trait because of the way LinkScala2Impls transforms supercalls to these traits. Luckily, we don't need to extend js.JSApp anymore to make a Hello World :P. The following command works, and is added to the CI: sbt sjsSandbox/run This generally remains a WIP. There are still a lot of Scala.js-specific features which are not supported, notably exports and non-native JS classes.
|
Ready for review :) |
|
Is the code in |
For the parts that are implemented, yes. |
Instead of having `Run.rootContext` hard-code the filtering.
Instead of its own `test_sjs`.
No description provided.