New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-project rename #5462

Merged
merged 2 commits into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@Duhemm
Copy link
Contributor

Duhemm commented Nov 19, 2018

There can still be failures when we renaming symbols that appear in imports and late-compilation happens. This particular case is fixed in #5276.

@Duhemm Duhemm added the area:ide label Nov 19, 2018

@Duhemm

This comment has been minimized.

Copy link
Contributor

Duhemm commented Nov 28, 2018

@smarter Can you take a look, please?

@Duhemm Duhemm requested a review from smarter Nov 28, 2018

Duhemm added some commits Nov 16, 2018

IDE: Look for overrides in the whole project
When doing go-to-definition, we used to look for symbols that override
the symbol selected for go to definition only in the same source file as
the one that was selected. This commit changes that, as suggested in the
review of #5208.

@Duhemm Duhemm force-pushed the dotty-staging:topic/ide-multi-project-rename branch from 2a64545 to 72053ca Nov 30, 2018

@Duhemm Duhemm merged commit 6eddf68 into lampepfl:master Nov 30, 2018

3 checks passed

CLA User signed CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/drone/pr the build was successful
Details

@Duhemm Duhemm deleted the dotty-staging:topic/ide-multi-project-rename branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment