-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename reflect/reify and make them plain methods #5474
Rename reflect/reify and make them plain methods #5474
Conversation
a3a157f
to
e73d3c3
Compare
Is that what we decided? I thought it was: (exp: Expr[T]).toTree
(tpe: Type[T]).toTypeTree
(tree: Tree).toExpr[T] An then replace the extension method |
Didn't we said that that was not good because both methods would still be called |
I believe the But it would be good to have extension methods for converting between def (e: Expr[T]) unseal[T]: Tree
def (t: Tree) seal[T]: Expr[T] |
Is it really ? It means that every time you press "." in the IDE it will show up, even though 99% it won't be what you're looking for. Not to mention that this means you'll have a hard time calling it on any class that defines its own
No, because if it's not an extension method you give it another name, like |
Only if you imported |
As discussed in the meeting, we will use def (e: Expr[T]) unseal[T]: Tree
def (t: Tree) seal[T]: Expr[T] |
e73d3c3
to
4270437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the minitest
in the community build as well
4270437
to
1af9030
Compare
I fixed |
Remove implicit conversion of the extension methods from the API