Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing TASTy Reflect type API #5529

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Add missing TASTy Reflect type API #5529

merged 2 commits into from
Nov 28, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Nov 28, 2018
@nicolasstucki nicolasstucki force-pushed the tasty-reflect-add-missing-type-api branch from 418aa2b to 757c3c7 Compare November 28, 2018 07:50
liufengyun
liufengyun approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

library/src/scala/tasty/reflect/Core.scala Show resolved Hide resolved
library/src/scala/tasty/reflect/Core.scala Show resolved Hide resolved
@nicolasstucki nicolasstucki merged commit f66225c into scala:master Nov 28, 2018
@nicolasstucki nicolasstucki deleted the tasty-reflect-add-missing-type-api branch November 28, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolasstucki @liufengyun