Run worksheets after willSave instead of didSave #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were triggering the worksheet run after a `didSave` event. This means that, if the file was unmodified, hitting `<ctrl-s>` would not re-run the worksheet, even though the previous output would disappear. We know run the worksheet after the `willSave` event, which is triggered regardless of the buffer state. This is not an issue for the language server which uses the tree that it has in memory rather than what's on disk at the moment.
smarter
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were triggering the worksheet run after a
didSaveevent. This meansthat, if the file was unmodified, hitting
<ctrl-s>would not re-runthe worksheet, even though the previous output would disappear.
We know run the worksheet after the
willSaveevent, which is triggeredregardless of the buffer state. This is not an issue for the language
server which uses the tree that it has in memory rather than what's on
disk at the moment.