Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5556: Check SAM types for realizability #5623

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fix #5556: Check SAM types for realizability #5623

merged 1 commit into from
Dec 17, 2018

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 16, 2018

Also: avoid shortcuts in findMember which can mask bad bounds

@odersky
Fix scala#5556: Check SAM types for realizablity
17cada8 
Also: avoid shortcuts in findMember which can mask bad bounds
@odersky
Copy link
Contributor Author

odersky commented Dec 16, 2018 •
edited by liufengyun
Loading

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/5623/ to see the changes.

Benchmarks is based on merging with master (fcc35d2)

@odersky odersky added the fasttrack Simple fix. Reviewer should merge or apply additional changes directly. label Dec 17, 2018
Blaisorblade
Blaisorblade approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@Blaisorblade Blaisorblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm away but this LGTM: we must check for bad bounds whenever we create a value, and the testcase shows that's not only when instantiating objects (which is checked on class definitions) but also when creating SAM values.

@Blaisorblade Blaisorblade assigned odersky and unassigned Blaisorblade Dec 17, 2018
@odersky
Copy link
Contributor Author

odersky commented Dec 17, 2018

@Blaisorblade OK thanks for the quick review!

@odersky odersky merged commit 2e17a6c into scala:master Dec 17, 2018
@allanrenucci allanrenucci deleted the fix-#5556 branch December 17, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blaisorblade Blaisorblade Blaisorblade approved these changes

Assignees

@odersky odersky

Labels
fasttrack Simple fix. Reviewer should merge or apply additional changes directly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odersky @dottybot @Blaisorblade