Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticDB generator #5761

Merged
merged 42 commits into from Feb 7, 2019
Merged

SemanticDB generator #5761

merged 42 commits into from Feb 7, 2019

Conversation

poechsel
Copy link
Contributor

This PR adds a first prototype of the semanticDB converter.

Due to some differences between dotty and scala2 some tests are marked as failed while they are not wrong. I would advise to check the output of the test suite manually.

@nicolasstucki nicolasstucki self-assigned this Jan 23, 2019
@nicolasstucki
Copy link
Contributor

@poechsel it looks like this RP needs a rebase.

library/src/scala/tasty/reflect/TypeOrBoundsOps.scala Outdated Show resolved Hide resolved
semanticdb/src/dotty/semanticdb/Main.scala Outdated Show resolved Hide resolved
semanticdb/src/dotty/semanticdb/Main.scala Outdated Show resolved Hide resolved
semanticdb/src/dotty/semanticdb/Main.scala Outdated Show resolved Hide resolved
vscode-dotty/package-lock.json Outdated Show resolved Hide resolved
vscode-dotty/package-lock.json Outdated Show resolved Hide resolved
@biboudis
Copy link
Contributor

biboudis commented Jan 30, 2019

After this gets rebased @poechsel it seems we can merge it.
I am putting it on the next milestone ;-) @nicolasstucki

Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@nicolasstucki nicolasstucki merged commit d70d69b into scala:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants