Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename scala.quoted.matching.{Bind => Sym} #7332

Merged
merged 1 commit into from
Sep 29, 2019

Conversation

nicolasstucki
Copy link
Contributor

Rename it to give it a meaningful name and avoid ambigouities with
scala.tasty.Reflection.Bind which may be used in the same code.

@nicolasstucki
Copy link
Contributor Author

Note the Sym is an expression like abstraction that wraps over a symbol

Rename it to give it a meaningful name and avoid ambigouities with
`scala.tasty.Reflection.Bind` which may be used in the same code.
@nicolasstucki nicolasstucki marked this pull request as ready for review September 27, 2019 16:38
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit f1d0b81 into scala:master Sep 29, 2019
@nicolasstucki nicolasstucki deleted the disambiguate-reflect-bind branch September 29, 2019 05:35
@nicolasstucki
Copy link
Contributor Author

@biboudis you may need to update some of your code

@biboudis
Copy link
Contributor

Indeed, I'll rebase! Thanks!

@anatoliykmetyuk anatoliykmetyuk added this to the 0.20 Tech Preview milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants