Add customizable names for definitions in quotes #7346
Conversation
nicolasstucki
force-pushed
the
spliced-names
branch
from
391c576
to
ff54544
Compare
nicolasstucki
changed the title
This allow naming val/def in quoted code with computed names
nicolasstucki
force-pushed
the
spliced-names
branch
from
ff54544
to
c4ac5f6
Compare
| * myVal + 1 | ||
| * ``` | ||
| */ | ||
| class showName(name: String) extends scala.annotation.Annotation |
There was a problem hiding this comment.
Minor: what about displayName or debugName? showName feels more like a verb.
There was a problem hiding this comment.
I chose show name because only the Expr.show will display it. Compiler debugging options as -Xprint will just print the annotations.
nicolasstucki
force-pushed
the
spliced-names
branch
from
8a948bb
to
04625bd
Compare
| } | ||
| def powerCodeD(n: Long, i: Int, x: Expr[Double])(given QuoteContext): Expr[Double] = | ||
| if (n == 0) '{1.0} | ||
| else if (n % 2 == 0) '{ @showName(${Expr("a" + i)}) val y = $x * $x; ${powerCodeD(n / 2, idx * 2, 'y)} } |
There was a problem hiding this comment.
Should we instead provide a means to developers for generating val definitions?
| else if (n % 2 == 0) '{ @showName(${Expr("a" + i)}) val y = $x * $x; ${powerCodeD(n / 2, idx * 2, 'y)} } | |
| else if (n % 2 == 0) { | |
| val y = named("a" + i, '{ $x * $x}) | |
| '{ $y; ${powerCodeD(n / 2, idx * 2, y)} } | |
| } |
Also, I’m very surprised that there is no name clash in the expanded code you shown. It seems that all the lines of the block are in the same lexical scope.
There was a problem hiding this comment.
Actually, I’m not sure about the suggestion above. It can not express something like '{ val MyExtractor(y) = $x * $x }, for instance.
Otherwise, could we support something like the following?
| else if (n % 2 == 0) '{ @showName(${Expr("a" + i)}) val y = $x * $x; ${powerCodeD(n / 2, idx * 2, 'y)} } | |
| else if (n % 2 == 0) { | |
| val y = name("a" + i) | |
| '{ val $y = $x * $x; ${powerCodeD(n / 2, idx * 2, y)} } | |
| } |
I believe we can’t, though…
There was a problem hiding this comment.
The annotation is the first step towards splicing a name. This PR is a starting point to support all those patterns. Ideally a '{ val $y = ... } will be desugared to '{ @showName(${Expr(y.toString)}) val y = ... }
nicolasstucki
force-pushed
the
spliced-names
branch
from
9450b69
to
2dd7c32
Compare
nicolasstucki
force-pushed
the
spliced-names
branch
from
2dd7c32
to
8fb7a44
Compare
|
@liufengyun I extracted the second part of this PR in #7388. This PR only contains the core/internal logic required to splice names in quotes. |
This allow naming val/def in quoted code with computed names