Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SemanticDB extractor #7379

Merged
merged 107 commits into from
Dec 13, 2019
Merged

Add SemanticDB extractor #7379

merged 107 commits into from
Dec 13, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 7, 2019

No description provided.

@odersky odersky force-pushed the add-semanticdb branch 3 times, most recently from 539294f to f42cfb5 Compare October 9, 2019 13:55
@bishabosha bishabosha force-pushed the add-semanticdb branch 9 times, most recently from c140334 to 2287e5c Compare October 21, 2019 16:01
olafurpg
olafurpg reviewed Nov 6, 2019
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress is looking great! Nice work @bishabosha

tests/semanticdb/InstrumentTyper.expect.scala Outdated Show resolved Hide resolved
tests/semanticdb/todo Outdated Show resolved Hide resolved
@bishabosha bishabosha force-pushed the add-semanticdb branch 3 times, most recently from 4654cc1 to 7a967a7 Compare November 7, 2019 16:25
@bishabosha
Copy link
Member

bishabosha commented Nov 11, 2019 •
edited
Loading

blocked by #7525 <- fix was merged

@bishabosha bishabosha force-pushed the add-semanticdb branch 12 times, most recently from b0ddee5 to 0c9c342 Compare November 15, 2019 17:53
@bishabosha
add kind queries to Scala3.infoOps
b31542b
@bishabosha
inspect inside definitions with a numbered empty name
9cb1d0a
@bishabosha
define anon classes
a051a03
@bishabosha
refactor tools
eb3ba6c
@bishabosha
Dont make occurrences for setters, test def with explicit setter syntax
6aea653
@bishabosha
better support paths and pattern defs
d774f5a
@bishabosha
exclude use occurrences of annotation constructors
69f3d60
@bishabosha
traverse parents if span exists
dc1e127
@bishabosha
implicit objects have correct props
298b2b4
@bishabosha
support pattern vals
afff105
@bishabosha
update TODO
057b158
@bishabosha
Resupport Ident patterns in pattern defs
bfbe08d
@bishabosha
Support named arguments
0bf31a9
@bishabosha
syntax changes and test result improvements
4a3071f
@bishabosha
delete dead code
ace6257
@bishabosha
output whole file and not diff in failure case
196c90c
@bishabosha
remove special case for Annotated, update expect for anon class change
f82a8c7
@bishabosha
refactor names and remove dead code
25fdafa
@bishabosha
drop -scansource setting
6a47cf6
@bishabosha
DRY SemanticdbTests
31aff29
@bishabosha
remove dependency on google diffutil
740c864
@bishabosha
rename target setting to semanticdbTarget
f02321a
@bishabosha
compile javacp files as part of expect tests
d594863
@bishabosha
Copy link
Member

I believe I have addressed everything

@anatoliykmetyuk anatoliykmetyuk merged commit 3130729 into scala:master Dec 13, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the add-semanticdb branch December 13, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha left review comments

@anatoliykmetyuk anatoliykmetyuk anatoliykmetyuk approved these changes

@olafurpg olafurpg Awaiting requested review from olafurpg

Assignees

@odersky odersky

Labels
area:semanticdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@odersky @bishabosha @olafurpg @anatoliykmetyuk