Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine semantics of inline parameters #8060

Merged
merged 2 commits into from Jan 27, 2020

Conversation

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jan 22, 2020

See docs/docs/reference/metaprogramming/inline.md

@nicolasstucki nicolasstucki self-assigned this Jan 22, 2020
@nicolasstucki nicolasstucki force-pushed the dotty-staging:inline-param-semantics branch 4 times, most recently from e4aae77 to c33f442 Jan 22, 2020
@nicolasstucki nicolasstucki force-pushed the dotty-staging:inline-param-semantics branch 10 times, most recently from 024a2ca to 919bd73 Jan 23, 2020
See docs/docs/reference/metaprogramming/inline.md
@nicolasstucki nicolasstucki force-pushed the dotty-staging:inline-param-semantics branch from 919bd73 to dd47092 Jan 24, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review Jan 24, 2020
@nicolasstucki nicolasstucki requested a review from liufengyun Jan 24, 2020
@nicolasstucki nicolasstucki added this to the 0.22 Tech Preview milestone Jan 26, 2020
Copy link
Contributor

liufengyun left a comment

LGTM

@@ -533,7 +533,7 @@ class TypeErasure(isJava: Boolean, semiEraseVCs: Boolean, isConstructor: Boolean
// but potentially re-introduced by ResolveSuper, when we add
// forwarders to mixin methods.
// See doc comment for ElimByName for speculation how we could improve this.
else MethodType(Nil, Nil, eraseResult(sym.info.finalResultType))
else MethodType(Nil, Nil, eraseResult(sym.info.finalResultType.underlyingIfRepeated(isJava)))

This comment has been minimized.

Copy link
@liufengyun

liufengyun Jan 27, 2020

Contributor

It would be good to check if we can move it earlier to simply the contract between phases.

This comment has been minimized.

Copy link
@nicolasstucki

nicolasstucki Jan 27, 2020

Author Contributor

That would also include val binding generated for repeated parameters.

docs/docs/reference/metaprogramming/inline.md Outdated Show resolved Hide resolved
@nicolasstucki nicolasstucki merged commit f00fa72 into lampepfl:master Jan 27, 2020
2 checks passed
2 checks passed
CLA User signed CLA
Details
continuous-integration/drone/pr Build is passing
Details
@nicolasstucki nicolasstucki deleted the dotty-staging:inline-param-semantics branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.