Redefine semantics of inline parameters #8060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
inline-param-semantics
branch
4 times, most recently
from
e4aae77
to
c33f442
Compare
nicolasstucki
force-pushed
the
inline-param-semantics
branch
10 times, most recently
from
024a2ca
to
919bd73
Compare
See docs/docs/reference/metaprogramming/inline.md
nicolasstucki
force-pushed
the
inline-param-semantics
branch
from
919bd73
to
dd47092
Compare
liufengyun
approved these changes
Jan 27, 2020
| @@ -533,7 +533,7 @@ class TypeErasure(isJava: Boolean, semiEraseVCs: Boolean, isConstructor: Boolean | |||
| // but potentially re-introduced by ResolveSuper, when we add | |||
| // forwarders to mixin methods. | |||
| // See doc comment for ElimByName for speculation how we could improve this. | |||
| else MethodType(Nil, Nil, eraseResult(sym.info.finalResultType)) | |||
| else MethodType(Nil, Nil, eraseResult(sym.info.finalResultType.underlyingIfRepeated(isJava))) | |||
There was a problem hiding this comment.
It would be good to check if we can move it earlier to simply the contract between phases.
There was a problem hiding this comment.
That would also include val binding generated for repeated parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See docs/docs/reference/metaprogramming/inline.md