Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ValueOfExpr to Unliftable #8503

Merged
merged 1 commit into from Mar 11, 2020
Merged

Rename ValueOfExpr to Unliftable #8503

merged 1 commit into from Mar 11, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Mar 11, 2020 •
edited

As the dual of Liftable, the concept should be named Unliftable.
Additionally when programmers did not know about ValueOfExpr, they have been asking is the was
an unliftable/unlift.

For a future PR: Should the Value.unapply extractor be renamed to Unlift.unapply or Expr.unapply (as Expr.apply is lifting)? See #8504

@nicolasstucki
Rename ValueOfExpr to Unliftable
bd9a3b9 
As the dual of Liftable, the concept should be named Unliftable.
Additionally when programmers did not know about ValueOfExpr, they have been asking is the was
an unliftable/unlift.
@nicolasstucki nicolasstucki self-assigned this Mar 11, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review March 11, 2020 08:16
@nicolasstucki nicolasstucki added this to the 0.23.0-RC1 milestone Mar 11, 2020
liufengyun
liufengyun approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's difficult to find a better name than Unliftable.

@nicolasstucki nicolasstucki merged commit f3c47a7 into scala:master Mar 11, 2020
@nicolasstucki nicolasstucki deleted the rename-valueof-expr-to-unliftable branch March 11, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
0.23.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolasstucki @liufengyun