Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplications and typo #14

Merged
merged 1 commit into from
Nov 28, 2012
Merged

Fix duplications and typo #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions AssignmentFeedback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ The following table indicates how often each of the issues occurred during this

### #4.1 Unnecessary recursive Computation for "weight" and / or "chars"

Every code tree (leaf or fork) contains the the full weight and list of characters. Therefore, implementing `def weight` and `def chars` does not require a recursive computation.
Every code tree (leaf or fork) contains the full weight and list of characters. Therefore, implementing `def weight` and `def chars` does not require a recursive computation.


### #4.2 List Concatenation with :::
Expand Down Expand Up @@ -129,7 +129,7 @@ Note that the `counter` parameter is not required, the method can be written as

### #4.4 Calling "sort" in a recursive Function

To sort the the list of frequencies, some solutions of `makeOrderedLeafList` call `sort` in every iteration - this is unnecessary, calling it once on the entire list would be enough. To avoid the problem, a helper method might be required. Example:
To sort the list of frequencies, some solutions of `makeOrderedLeafList` call `sort` in every iteration - this is unnecessary, calling it once on the entire list would be enough. To avoid the problem, a helper method might be required. Example:

def makeOrderedLeafList(freqs: List[(Char, Int)]): List[Leaf] =
freqs.sortWith((a,b) => a._2 <= b._2) match {
Expand Down Expand Up @@ -169,7 +169,7 @@ is better written as follows:

### Week 3: Object-Oriented Sets (TweetSet)

The following table indicates how often each of the issues occured during this assignment (the [Scala Style Guide](?page=ScalaStyleGuide) describes the first 12 issues).
The following table indicates how often each of the issues occurred during this assignment (the [Scala Style Guide](?page=ScalaStyleGuide) describes the first 12 issues).

<table>
<tr><td>#1 (casts)</td><td>1 %</td></tr>
Expand Down