Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for monolithic #5

Merged
merged 17 commits into from
Feb 23, 2020
Merged

Rebuild for monolithic #5

merged 17 commits into from
Feb 23, 2020

Conversation

GotenXiao
Copy link
Member

This overhauls the compose stack for use with the monolithic stack. Also includes some minor quality-of-life improvements for first time users.

@VibroAxe
Copy link
Member

VibroAxe commented Jul 6, 2019

Seems plausible to me?

Edit
Having tested, also lgtm. Few comments in line

Copy link
Member

@VibroAxe VibroAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

.env Outdated Show resolved Hide resolved
.env Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
.env Show resolved Hide resolved
@PedanXr
Copy link
Contributor

PedanXr commented Jul 29, 2019

Sorry, I don't know how to mark it in GitHub but I found an error while cloning this branch. In docker-compose.yml line 7: Change ${DNS_IP} to ${DNS_BIND_IP}

@GotenXiao
Copy link
Member Author

Sorry, I don't know how to mark it in GitHub but I found an error while cloning this branch. In docker-compose.yml line 7: Change ${DNS_IP} to ${DNS_BIND_IP}

Thanks - I'd missed that the first time around.

.env Outdated Show resolved Hide resolved
@GotenXiao
Copy link
Member Author

Rebased to fix merge conflict.

@VibroAxe VibroAxe merged commit 9e19a8c into master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants