-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyfilling mbed for extensions #13
Merged
finneyj
merged 16 commits into
lancaster-university:master
from
microbit-sam:extension-polyfills
Nov 6, 2020
Merged
Polyfilling mbed for extensions #13
finneyj
merged 16 commits into
lancaster-university:master
from
microbit-sam:extension-polyfills
Nov 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-sam
commented
Nov 3, 2020
Moved to compat version of MemberFunctionCallback
This doesn't compile properly in PXT..
|
This reverts commit fc1a8d1.
Fixed by using I can replace it with a check for a define if |
Now uses |
Thanks Sam - this looks really good. nice job - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: PwmOut, InterruptIn, DigitalIn, DigitalOut, Ticker, (Mbed)Timer
Extensions wishing to use any of these will need to make sure that they
#include "mbed.h"
Is there a define extensions can use determine which timer to use? e.g.
Timer
in on v1, andMbedTimer
on v2Note: commit messages referencing extensions were chosen as they were top of this list rather than any favoritism!
microsoft/pxt-microbit#3506
@finneyj please critique!