fix for issue #252: bug in MicroBitUARTService#read when buffer conta… #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad when buffer contains NULL character Signed-off-by: Benjamin Cabé <benjamin@eclipse.org>
|
Should the && operands be swapped as well, to avoid reading and discarding an extra character after len have been read? |
|
Yup, @martinwork . We really need a Stream abstraction, it's been on our todo list for a while. This is another place where the same broken logic has cropped up again, I suspect because it's been implemented across 3 different classes, and the first time it was caught the change wasn't applied here. |
…ters have been read Signed-off-by: Benjamin Cabé <benjamin@eclipse.org>
|
Good catch @martinwork. I updated the condition. |
|
any plan to merge this? |
|
Apologies @kartben - my many hands are full as usual. :-) Looks great, very happy to merge. Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ins NULL character
Signed-off-by: Benjamin Cabé benjamin@eclipse.org