New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traces mechanism is unnecessarily creating strings for the garbage collector #61

Closed

namel opened this issue Oct 6, 2017 · 1 comment

Assignees

Member

namel commented Oct 6, 2017

Calls like this one are generating strings and polluting memory, even when tracing is disabled:

this.gameEngine.trace.warn(`step drift ${checkType}. [${clientStep} > ${serverStep} + ${maxLead}] Client is ahead of server.  Delaying next step.`);

Solution: the trace functions should be passed a callback which builds the string.

The text was updated successfully, but these errors were encountered:

namel self-assigned this

Member Author

namel commented Oct 23, 2017

fixed in V2

namel closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment