Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #3

Closed
rsbivand opened this issue Dec 14, 2022 · 4 comments
Closed

Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** #3

rsbivand opened this issue Dec 14, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@rsbivand
Copy link

This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html). Since raster 3.6.3, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.
@idblr idblr added the enhancement New feature or request label Dec 14, 2022
@idblr
Copy link
Collaborator

idblr commented Dec 14, 2022

Thanks, @rsbivand. I'll get this sorted asap.

idblr added a commit that referenced this issue Dec 16, 2022
@idblr
Migrated R-spatial dependencies
8bc4025 
* Replaced `raster`, `rgeos`, and `sp` packages in Imports with `terra` and `sf` because of imminent package retirements
* Removed `maptools` from Suggests (replaced with new internal function `as.im.SpatRaster()`)
* Thank you, [Roger Bivand](https://github.com/rsbivand), for the notice. Relates to [ndi Issue #3](#3)
* Note: `raster` is a dependency of `RStoolbox` (at present) which is used in the vignette
* Updated test, examples, vignette, and documentation throughout
* Added GitHub R-CMD-check
@idblr
Copy link
Collaborator

idblr commented Dec 16, 2022

@rsbivand I have a new branch dev_rspatial_depends with the R-spatial package migration. It's passing checks, but please let me know if it was successful.

maptools was in Suggests because it's used in an example in the vignette to convert an object of class RasterLayer to im. I designed a crude replacement with a new internal function to convert an object of class SpatRaster to im. I hope this stopgap is temporary and this conversion will be possible in terra or the spatstat suite.

Also, an example in the vignette uses the RStoolbox package (in Suggests) that currently depends on raster so envi can fully migrate once RStoolbox does.

@rsbivand
Copy link
Author

00check.log for R_LIBS=/home/rsb/lib/r_libs R CMD check --as-cran envi_0.1.16.9000.tar.gz built from the dev_rspatial_depends branch. Thanks! See also
r-spatial/evolution#8.

@idblr
Copy link
Collaborator

idblr commented Dec 19, 2022

Thanks, @rsbivand!

@idblr idblr closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

dev_rspatial_depends lance-waller-lab/envi
2 participants
@rsbivand @idblr