Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drop_column API to remove a column from a dataset #1076

Closed
wjones127 opened this issue Jul 17, 2023 · 1 comment · Fixed by #1904
Closed

Add drop_column API to remove a column from a dataset #1076

wjones127 opened this issue Jul 17, 2023 · 1 comment · Fixed by #1904
Assignees
@wjones127
Labels
enhancement New feature or request rust Rust related tasks

Comments

@wjones127
Copy link
Contributor

This should be doable with metadata only, I think.

TODO: how to write the fields field in DataFile when there is an unused field?

lance/protos/format.proto

Line 143 in 4647312

repeated int32 fields = 2;

@wjones127 wjones127 added enhancement New feature or request rust Rust related tasks labels Jul 17, 2023
@wjones127
Copy link
Contributor Author

wjones127 commented Jul 17, 2023 •
edited

Ids are positions. But ids might be removed. We need to maintain an id high water mark.

We might need a writer feature flag for this for the high water mark.

@wjones127 wjones127 self-assigned this Feb 2, 2024
@wjones127 wjones127 mentioned this issue Feb 2, 2024
Merged
wjones127 added a commit that referenced this issue Feb 3, 2024
@wjones127
feat(python): expose drop_columns() in Python (#1904)
5d898a7 
Renames the Rust method `drop()` to `drop_columns()` for clarity and
also alignment with `add_columns()` and `alter_columns()`.

Closes #1076
Related #1674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wjones127 wjones127

Labels
enhancement New feature or request rust Rust related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(python): expose drop_columns() in Python wjones127/lance
1 participant
@wjones127