Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: table.proto message DataFragment documentation confusion #2345

Closed
broccoliSpicy opened this issue May 17, 2024 · 1 comment
Closed

doc: table.proto message DataFragment documentation confusion #2345

broccoliSpicy opened this issue May 17, 2024 · 1 comment

Comments

@broccoliSpicy
Copy link
Contributor

source link

 // Number of original rows in the fragment, not counting deletions. To compute
  // the current number of rows, subtract `deletion_file.num_deleted_rows` from
  // this value.
  uint64 physical_rows = 4;

not counting deletions -> counting deleted rows?

@wjones127
Copy link
Contributor

Hmm. I suppose could say "Number of original rows in the fragment. This includes rows that are now marked with deletion tombstones." I think the existing second sentence is good and clarifies it though.

@broccoliSpicy broccoliSpicy changed the title doc: table.proto message IndexMetadata documentation confusion doc: table.proto message DataFragment documentation confusion May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants