feat: support keyboard interrupt in Python #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
reviewed
Oct 19, 2023
Comment on lines
469
to
487
| def test_keyboard_interrupt(tmp_path, dataset): | ||
| assert not dataset.has_index | ||
| ann_ds = lance.write_dataset(dataset.to_table(), tmp_path / "indexed.lance") | ||
|
|
||
| try: | ||
| start_time = time.monotonic() | ||
|
|
||
| # Create an index in a thread | ||
| thread = Thread(target=ann_ds.create_index, args=("vector"), kwargs=dict( | ||
| index_type="IVF_PQ", | ||
| num_partitions=4, | ||
| num_sub_vectors=16, | ||
| )) | ||
|
|
||
| raise KeyboardInterrupt() | ||
| except KeyboardInterrupt: | ||
| end_time = time.monotonic() | ||
|
|
||
| assert end_time - start_time < 0.2 |
There was a problem hiding this comment.
Instead of testing at this level you could potentially write a unit test in executor.rs that takes an endless dummy task (async sleep in a loop) and then make sure you can interrupt it.
There was a problem hiding this comment.
Eh I give up on testing this for now. I've confirmed manually this allows keyboard interrupt, and is especially handy for the create index part.
wjones127
changed the title
wjones127
force-pushed
the
wjones127/keyboard-interrupt
branch
from
e27c347
to
ff8749c
Compare
eddyxu
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1436.