fix: map the ErrorKind::NotFound to Error::NotFound #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it possible to recognize whether we are removing something not exists see lancedb/lancedb#884 Signed-off-by: BubbleCal <bubble-cal@outlook.com>
eddyxu
approved these changes
Feb 26, 2024
BubbleCal
added a commit
to BubbleCal/lancedb
that referenced
this pull request
Feb 26, 2024
…table this will work after upgrading lance with lancedb/lance#1995 merged Signed-off-by: BubbleCal <bubble-cal@outlook.com>
BubbleCal
added a commit
to lancedb/lancedb
that referenced
this pull request
Feb 28, 2024
…table (#1022) this will work after upgrading lance with lancedb/lance#1995 merged see #884 for details Signed-off-by: BubbleCal <bubble-cal@outlook.com>
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
…table (lancedb#1022) this will work after upgrading lance with lancedb/lance#1995 merged see lancedb#884 for details Signed-off-by: BubbleCal <bubble-cal@outlook.com>
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
…table (lancedb#1022) this will work after upgrading lance with lancedb/lance#1995 merged see lancedb#884 for details Signed-off-by: BubbleCal <bubble-cal@outlook.com>
westonpace
pushed a commit
to lancedb/lancedb
that referenced
this pull request
Apr 5, 2024
…table (#1022) this will work after upgrading lance with lancedb/lance#1995 merged see #884 for details Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it possible to recognize whether we are removing something not exists.
see lancedb/lancedb#884