fix: don't use pushdown scan if a custom batch size has been set #2277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pushdown scan currently requires fully materializing a batch in memory. As a result, it is not capable of supporting the
batch_size
parameter in the scanner. This fix is not great, it disables pushdown optimization when a batch size is specified, but if users truly need a batch size (to constrain memory) then its better to give them what they ask for at higher cost.I would like to do a more correct fix soon but probably not until I work on pushdown for v2 (I'm still not sure if the "late materialization" will be part of the file reader itself or if we still need a dedicated pushdown node.