feat: add list_indices to the async api #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
force-pushed
the
feat/new-api-list-indices
branch
from
8ec90bd
to
f8ddb6d
Compare
wjones127
reviewed
Mar 12, 2024
| for field_id in &idx.fields { | ||
| let field = dataset.schema().field_by_id(*field_id).ok_or_else(|| Error::Runtime { message: format!("The index with name {} and uuid {} referenced a field with id {} which does not exist in the schema", idx.name, idx.uuid, field_id) })?; | ||
| if field.data_type().is_nested() { | ||
| // Temporary hack to determine if an index is scalar or vector |
There was a problem hiding this comment.
See my note here: lancedb/lance#2039 (comment)
wjones127
approved these changes
Mar 12, 2024
westonpace
force-pushed
the
feat/new-api-list-indices
branch
from
f8ddb6d
to
5c2bf51
Compare
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
westonpace
added a commit
that referenced
this pull request
Apr 5, 2024
alexkohler
pushed a commit
to alexkohler/lancedb
that referenced
this pull request
Apr 20, 2024
Closes. lancedb#1074 This pull request extends the `delete` method to accept the parameter `delete('true')` to bypass the filter when `predicate == 'true'`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.