better error msg for query vector with wrong dim #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonpace
approved these changes
Mar 21, 2024
rust/lancedb/src/table.rs
Outdated
Comment on lines
1188
to
1195
| if !matches!(field.data_type(), arrow_schema::DataType::FixedSizeList(f, dim) if f.data_type().is_floating() && dim == query_vector.len() as i32) | ||
| { | ||
| return Err(Error::Schema { | ||
| let schema_vec_dim = | ||
| if let arrow_schema::DataType::FixedSizeList(_, dim) = field.data_type() { | ||
| dim | ||
| } else { | ||
| unreachable!() | ||
| }; |
There was a problem hiding this comment.
This is a little hard to follow. Maybe it would be easier now to just do..
if let arrow_schema::DataType::FixedSizeList(f, dim) = field.data_type()) {
if !f.data_type.is_floating() {
// Error, not a float
} else if dim != query_vector.len() {
// Error, not correct dimension
}
} else {
// Error, not a fixed-size-list type
}
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
raghavdixit99
pushed a commit
to raghavdixit99/lancedb
that referenced
this pull request
Apr 5, 2024
westonpace
pushed a commit
that referenced
this pull request
Apr 5, 2024
alexkohler
pushed a commit
to alexkohler/lancedb
that referenced
this pull request
Apr 20, 2024
…old files (lancedb#1140) * Added support for a cleanup_old_versions function which will remove expired files from a dataset --------- Co-authored-by: Will Jones <willjones127@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.