New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix path on remote create_table and check for error response #1244

Merged

rpgreen merged 2 commits into main from rpgreen/fix-remote-create-table-path

Apr 28, 2024

Contributor

rpgreen commented Apr 26, 2024 •

edited

create_table() was implemented for remote DB but the path was missing the trailing '/'
It was not handling the 404 error response from phalanx and incorrectly returning a RemoteTable


          fix: fix path on remote create_table and check for error response

9eaa93a

rpgreen requested a review from westonpace

April 26, 2024 14:47


          run cargo fmt

5ecd42a

albertlockett approved these changes

View reviewed changes

westonpace approved these changes

View reviewed changes

rpgreen merged commit 0528abd into main

8 checks passed

rpgreen deleted the rpgreen/fix-remote-create-table-path branch

April 28, 2024 14:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment