Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): return ValueError if passed unknown args to connect() #1265

Merged
merged 1 commit into from
May 4, 2024

Conversation

wjones127
Copy link
Contributor

It's confusing to users that keyword arguments from the async API like storage_options are accepted by connect(), but don't do anything. We should error if unknown arguments are passed instead.

@wjones127 wjones127 merged commit 82a1da5 into lancedb:main May 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants