Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Metrics types. #135

Merged
merged 3 commits into from
Jun 3, 2023
Merged

[Doc] Metrics types. #135

merged 3 commits into from
Jun 3, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 2, 2023

Closes #129

@eddyxu eddyxu marked this pull request as ready for review June 2, 2023 23:51
Copy link
Contributor

@gsilvestrin gsilvestrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@@ -87,7 +87,7 @@ There are a couple of parameters that can be used to fine-tune the search:
=== "Javascript"
```javascript
const results = await table
.search(Array(1536).fill(1.2))
.search(Array(768).fill(1.2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to keep this 1536 since it matches the create_index example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the javascript and python examples are different parameters. i can do another round to make two language the same.

.limit(20)
.execute()
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe filtering / projection should be moved here since they are not related to ANN?

@eddyxu eddyxu merged commit cdd08ef into main Jun 3, 2023
@eddyxu eddyxu deleted the lei/metric_types branch June 14, 2023 02:35
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this pull request Apr 5, 2024
alexkohler pushed a commit to alexkohler/lancedb that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Improve document w.r.t. of Metric/Distance function
2 participants