-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Metrics types. #135
[Doc] Metrics types. #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
@@ -87,7 +87,7 @@ There are a couple of parameters that can be used to fine-tune the search: | |||
=== "Javascript" | |||
```javascript | |||
const results = await table | |||
.search(Array(1536).fill(1.2)) | |||
.search(Array(768).fill(1.2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to keep this 1536 since it matches the create_index
example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, the javascript and python examples are different parameters. i can do another round to make two language the same.
.limit(20) | ||
.execute() | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe filtering / projection should be moved here since they are not related to ANN?
Closes #129