Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port remote connection client into lancedb #194

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

chebbyChefNEQ
Copy link
Contributor

@chebbyChefNEQ chebbyChefNEQ commented Jun 14, 2023

  • to_df() is now async, added to_df_blocking to convenience
  • add remote lancedb client to public lancedb
  • make lancedb connection class understand url scheme lancedb+<connection_type>://<host>:<port>.

@chebbyChefNEQ chebbyChefNEQ force-pushed the rmeng/remote-client-port-in branch 14 times, most recently from 0a37264 to a625a94 Compare June 15, 2023 20:32
python/tests/test_e2e_remote_db.py Show resolved Hide resolved
python/lancedb/table.py Outdated Show resolved Hide resolved
python/lancedb/db.py Outdated Show resolved Hide resolved
python/lancedb/db.py Show resolved Hide resolved
python/lancedb/db.py Outdated Show resolved Hide resolved
python/lancedb/query.py Show resolved Hide resolved
python/lancedb/remote/client.py Show resolved Hide resolved
python/lancedb/table.py Outdated Show resolved Hide resolved
python/pyproject.toml Outdated Show resolved Hide resolved
python/lancedb/query.py Outdated Show resolved Hide resolved
@chebbyChefNEQ chebbyChefNEQ force-pushed the rmeng/remote-client-port-in branch 4 times, most recently from eea28cb to 04445aa Compare June 15, 2023 22:15
Copy link
Contributor

@eddyxu eddyxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, pending a few small nits.

python/lancedb/remote/__init__.py Outdated Show resolved Hide resolved
python/lancedb/remote/__init__.py Show resolved Hide resolved
python/lancedb/remote/client.py Show resolved Hide resolved
@chebbyChefNEQ chebbyChefNEQ merged commit cbb56e2 into main Jun 15, 2023
8 checks passed
@chebbyChefNEQ chebbyChefNEQ deleted the rmeng/remote-client-port-in branch June 15, 2023 22:57
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this pull request Apr 5, 2024
* to_df() is now async, added `to_df_blocking` to convenience
* add remote lancedb client to public lancedb
* make lancedb connection class understand url scheme
`lancedb+<connection_type>://<host>:<port>`.
alexkohler pushed a commit to alexkohler/lancedb that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants