-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: switch python examples to be row based #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this isn't quite what we want. The row-based examples shouldn't use Pandas at all, just list of dict. And when we do use Pandas, being column-oriented is fine.
@wjones127 i think some of these are specifically within the section on pandas integration so those are ok. But I agree that in general we should default to list-of-dict |
Yeah I agree many of these places should stay as Pandas and are fine as is. So my complaint there is this PR changes them to do row-wise construction with Pandas, which is weird. We should leave the Pandas-specific examples alone, and focus on removing Pandas from places where Pandas isn't relevant. |
Co-authored-by: Will Jones <willjones127@gmail.com>
a07bc28
to
3099da1
Compare
@wjones127 @changhiskhan Thanks for the feedback, fully agreed.. I've pushed changes, please see if everything is addressed. |
See #551