Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: switch python examples to be row based #554

Merged
merged 5 commits into from
Oct 14, 2023
Merged

docs: switch python examples to be row based #554

merged 5 commits into from
Oct 14, 2023

Conversation

rok
Copy link
Contributor

@rok rok commented Oct 11, 2023

See #551

python/lancedb/db.py Outdated Show resolved Hide resolved
python/lancedb/table.py Outdated Show resolved Hide resolved
Copy link
Contributor

@changhiskhan changhiskhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending CI

Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't quite what we want. The row-based examples shouldn't use Pandas at all, just list of dict. And when we do use Pandas, being column-oriented is fine.

python/lancedb/table.py Outdated Show resolved Hide resolved
python/lancedb/table.py Outdated Show resolved Hide resolved
@changhiskhan
Copy link
Contributor

I think this isn't quite what we want. The row-based examples shouldn't use Pandas at all, just list of dict. And when we do use Pandas, being column-oriented is fine.

@wjones127 i think some of these are specifically within the section on pandas integration so those are ok. But I agree that in general we should default to list-of-dict

@wjones127
Copy link
Contributor

i think some of these are specifically within the section on pandas integration so those are ok. But I agree that in general we should default to list-of-dict

Yeah I agree many of these places should stay as Pandas and are fine as is. So my complaint there is this PR changes them to do row-wise construction with Pandas, which is weird. We should leave the Pandas-specific examples alone, and focus on removing Pandas from places where Pandas isn't relevant.

Co-authored-by: Will Jones <willjones127@gmail.com>
@rok rok force-pushed the 551 branch 4 times, most recently from a07bc28 to 3099da1 Compare October 12, 2023 13:41
@rok
Copy link
Contributor Author

rok commented Oct 12, 2023

@wjones127 @changhiskhan Thanks for the feedback, fully agreed.. I've pushed changes, please see if everything is addressed.

@changhiskhan changhiskhan merged commit 6d66404 into main Oct 14, 2023
11 checks passed
@changhiskhan changhiskhan deleted the 551 branch October 14, 2023 21:07
raghavdixit99 pushed a commit to raghavdixit99/lancedb that referenced this pull request Apr 5, 2024
alexkohler pushed a commit to alexkohler/lancedb that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants